fix(relay): multi-value #h filters must not narrow to first channel (#4579) - #4624
Open
IgorGanapolsky wants to merge 1 commit into
Open
fix(relay): multi-value #h filters must not narrow to first channel (#4579)#4624IgorGanapolsky wants to merge 1 commit into
IgorGanapolsky wants to merge 1 commit into
Conversation
…lock#4579) extract_channel_id_from_filter returned the first parseable #h UUID. nostr::Filter stores generic_tags in a sorted set, so multi-channel queries (e.g. desktop Workflows kind:30620 over every member channel) were silently scoped to the lexicographically smallest id and dropped every other channel from SQL. - channel_scope_from_filter: one id → channel_id; many → channel_ids - apply_access_scope intersects multi-#h lists instead of replacing them - unit tests pin the fail-before / pass-after behavior Signed-off-by: Igor Ganapolsky <201209+IgorGanapolsky@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4579: a filter with multiple
#hchannel values was silently answered as if it named only the lexicographically first channel.Supersedes #4598 (same fix; that PR failed DCO — this commit is
Signed-off-by).Failure (before)
extract_channel_id_from_filterreturned the first parseable UUID from#h.nostr::Filterstoresgeneric_tagsin a sorted set, so multi-channel queries always collapsed to the smallest id. SQL then scoped to that one channel; the Rust post-filter can only remove rows, never restore dropped channels.Concrete impact: Desktop's global Workflows view batches
kind:30620with every member channel in#h. Workflows living in any channel other than the first alphabetically never appeared.After
#hvalueschannel_id = that idchannel_id = None,channel_ids = all of themapply_access_scope_to_queryintersects a pre-set multi-#hlist with the caller's accessible channels instead of replacing it with the full set.Verification
cargo test -p buzz-relay --lib handlers::req::tests51 passed (full
handlers::req::testsmodule), including:extract_channel_id_from_filter_multi_h_returns_nonefilter_to_query_params_multi_h_sets_channel_ids_not_first_onlyapply_access_scope_intersects_multi_h_channel_ids